test: Convert explain join tests to new explain setup #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`typeJoinOne`, or `typeJoinMany`cases. `type_join_test.go` file will contain mixed tests. Following commits will add the separated `typeJoinOne` and `typeJoinMany` test cases in their respective files.
shahzadlone
added
area/testing
Codecov Report
@@ Coverage Diff @@
## develop #1476 +/- ##
===========================================
+ Coverage 72.17% 72.25% +0.08%
===========================================
Files 185 185
Lines 18226 18226
===========================================
+ Hits 13154 13169 +15
+ Misses 4031 4022 -9
+ Partials 1041 1035 -6 |
shahzadlone
force-pushed
the
test/refactor-join-explain-tests
branch
from
939d43a
to
11a8d87
Compare
shahzadlone
changed the title
shahzadlone
changed the title
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…1476) ## Relevant issue(s) - Part of sourcenetwork#953 - Resolves sourcenetwork#1475 ## Description Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based testing setup. sourcenetwork#953 Has a lot more detail on the entire plan. - Splits type join one tests into a separate file. - Added some type join many tests into a separate file. - This PR converts all the default typeJoin explain tests to the new explain setup. - Keeps the mixed test that use both type of joins in the original file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Description
Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based testing setup. #953 Has a lot more detail on the entire plan.