fix: Make nested joins work correctly from primary direction #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
changed the title
No changes to the test content
Removes the extra fields from the schema, and reorders stuff so that it is read in the order that it is used. Does also change the test itself, so that now it does actually test from the primary direction all the way through.
This results in the scan nodes of the inner most query (subType) trying to scan with the parent prefix - e.g. reading books from within the [publisher][doc1] prefix.
Some of these would fail before the fix was implemented.
Some of these would fail before the fix was implemented.
AndrewSisley
force-pushed
the
1469-connor-nested-query
branch
from
61d8671
to
268b4c0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1491 +/- ##
===========================================
+ Coverage 72.09% 72.22% +0.12%
===========================================
Files 185 185
Lines 18241 18239 -2
===========================================
+ Hits 13151 13173 +22
+ Misses 4047 4028 -19
+ Partials 1043 1038 -5
|
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…etwork#1491) ## Relevant issue(s) Resolves sourcenetwork#1490 ## Description Issue found by Digital Gaia. Nesting joins would result in the parent span being propagated into the child/subType scanNode, this caused the scan node to scan the wrong prefix and return no inner child records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1490
Description
Issue found by Digital Gaia. Nesting joins would result in the parent span being propagated into the child/subType scanNode, this caused the scan node to scan the wrong prefix and return no inner child records.