Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CLI client request from file #1503

Merged

Conversation

orpheuslummis
Copy link
Contributor

Relevant issue(s)

Resolves #1258

Description

Adds support to read from a file to the client query CLI command, via -f flag, and a simple test for it, and two related examples in the /examples directory.

@orpheuslummis orpheuslummis added action/no-benchmark Skips the action that runs the benchmark. area/cli Related to the CLI binary labels May 15, 2023
@orpheuslummis orpheuslummis requested a review from a team May 15, 2023 17:34
@orpheuslummis orpheuslummis self-assigned this May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1503 (610608f) into develop (db4b853) will decrease coverage by 0.14%.
The diff coverage is 51.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1503      +/-   ##
===========================================
- Coverage    72.16%   72.03%   -0.14%     
===========================================
  Files          185      185              
  Lines        18239    18271      +32     
===========================================
- Hits         13162    13161       -1     
- Misses        4037     4063      +26     
- Partials      1040     1047       +7     
Impacted Files Coverage Δ
node/node.go 61.09% <30.76%> (-1.51%) ⬇️
net/peer.go 48.97% <57.14%> (+0.17%) ⬆️
cli/request.go 40.36% <66.66%> (+3.63%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@orpheuslummis
Copy link
Contributor Author

this v0.5.1 or v0.6 ?

@AndrewSisley
Copy link
Contributor

this v0.5.1 or v0.6 ?

I vote to merge it now :)

@orpheuslummis orpheuslummis merged commit c4b33f0 into sourcenetwork:develop May 15, 2023
9 checks passed
@fredcarle fredcarle added this to the DefraDB v0.6 milestone Jul 17, 2023
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#1258 

## Description

Adds support to read from a file to the `client query` CLI command, via
`-f` flag, and a simple test for it, and two related examples in the
`/examples` directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/cli Related to the CLI binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client query to support -f to read query from file
3 participants