test: Add DB/Node Restart tests #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/testing
This commit is broken, and is fixed by Fred and then cleaned up by Andrew over the next few commits.
AndrewSisley
force-pushed
the
1082-test-restart-with-fred-2
branch
from
1f4c45b
to
393acac
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1504 +/- ##
===========================================
- Coverage 72.16% 72.06% -0.10%
===========================================
Files 185 185
Lines 18239 18260 +21
===========================================
- Hits 13162 13159 -3
- Misses 4037 4056 +19
- Partials 1040 1045 +5
|
Cleans up the messy wip code commited earlier.
AndrewSisley
force-pushed
the
1082-test-restart-with-fred-2
branch
from
393acac
to
e1f9703
Compare
fredcarle
approved these changes
May 15, 2023
😆 I thought I fixed the change detector earlier but hadn't - so the other have at least until then 😁 |
Looks like this is somehow the first new test not either in a new package, or a P2P test, since the change detector was reactivated
Was an existing change detector bug - this was just the first test to hit it. |
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1082 ## Description Adds DB/Node Restart tests. This will be required by Lens (e.g. to make sure migrations are not lost on restart). IIRC I think this also found sourcenetwork#1482 (fixed by Fred). --------- Co-authored-by: Fred Carle <fredcarle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1082
Description
Adds DB/Node Restart tests. This will be required by Lens (e.g. to make sure migrations are not lost on restart). IIRC I think this also found #1482 (also fixed by Fred).
Fred was a massive help here and fixed the difficult bits when I flaked out on Friday :) Any commit that lists him as an author are his, I am only tagged in them having rebased them.
Commits are messy as anything as I wanted to preserve the level of credit due to Fred, and I'd suggest reviewing this PR at PR level as cleanup has not been squashed into commits introducing broken/messy code.
I will merge this when approved, whether that is 0.5.1 or 0.6 - it introduces no breaking (or risky) changes to the production code.