Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for foo_id field name clashes #1521

Merged
merged 1 commit into from
May 18, 2023

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1468

Description

Adds tests for foo_id field name clashes with relational id fields.

Fixing the issues is out of scope.

@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite action/no-benchmark Skips the action that runs the benchmark. labels May 18, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.6 milestone May 18, 2023
@AndrewSisley AndrewSisley requested a review from a team May 18, 2023 21:09
@AndrewSisley AndrewSisley self-assigned this May 18, 2023
@AndrewSisley AndrewSisley changed the title test: Add tests for foo_id field name clashes with relationals test: Add tests for foo_id field name clashes May 18, 2023
@AndrewSisley AndrewSisley changed the title test: Add tests for foo_id field name clashes tests: Add tests for foo_id field name clashes May 18, 2023
@AndrewSisley AndrewSisley changed the title tests: Add tests for foo_id field name clashes tests: Add tests for foo_id field name clashes May 18, 2023
@AndrewSisley AndrewSisley changed the title tests: Add tests for foo_id field name clashes test: Add tests for foo_id field name clashes May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1521 (983f176) into develop (76b7c87) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1521      +/-   ##
===========================================
+ Coverage    72.04%   72.11%   +0.07%     
===========================================
  Files          185      185              
  Lines        18295    18295              
===========================================
+ Hits         13180    13193      +13     
+ Misses        4068     4058      -10     
+ Partials      1047     1044       -3     

see 5 files with indirect coverage changes

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, Thanks for documenting these.

@AndrewSisley AndrewSisley merged commit b24d5b4 into sourcenetwork:develop May 18, 2023
8 of 12 checks passed
@AndrewSisley AndrewSisley deleted the 1468-foo-id-field branch May 18, 2023 21:47
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#1468 

## Description

Adds tests for foo_id field name clashes with relational id fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/testing Related to any test or testing suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No tests for defining field whose name clashes with foo_id field
2 participants