Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to ipfs boxo 0.10.0 #1573

Merged
merged 1 commit into from
Jun 13, 2023
Merged

chore: Update to ipfs boxo 0.10.0 #1573

merged 1 commit into from
Jun 13, 2023

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #1572

Description

This PR updates ipfs boxo to 0.10.0.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added the dependencies Related to dependencies label Jun 13, 2023
@fredcarle fredcarle added this to the DefraDB v0.6 milestone Jun 13, 2023
@fredcarle fredcarle requested a review from a team June 13, 2023 14:37
@fredcarle fredcarle self-assigned this Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (c9e4355) 72.27% compared to head (c15d9d3) 72.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1573      +/-   ##
===========================================
- Coverage    72.27%   72.21%   -0.06%     
===========================================
  Files          185      185              
  Lines        18477    18475       -2     
===========================================
- Hits         13353    13340      -13     
- Misses        4075     4085      +10     
- Partials      1049     1050       +1
Flag Coverage Δ
all-tests 72.21% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
merkle/clock/ipld.go 24.62% <ø> (-2.25%) ⬇️
net/process.go 83.19% <100.00%> (ø)

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e4355...c15d9d3. Read the comment docs.

AndrewSisley
AndrewSisley approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Fred

@fredcarle fredcarle merged commit 96ba89c into sourcenetwork:develop Jun 13, 2023
10 checks passed
@fredcarle fredcarle deleted the fredcarle/chore/ipfs-boxo-0.10 branch June 13, 2023 14:58
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@fredcarle
chore: Update to ipfs boxo 0.10.0 (sourcenetwork#1573)
9fa1170 
## Relevant issue(s)

Resolves sourcenetwork#1572 

## Description

This PR updates ipfs boxo to 0.10.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

Assignees

@fredcarle fredcarle

Labels
dependencies Related to dependencies
Projects
None yet
Milestone
DefraDB v0.6
Development

Successfully merging this pull request may close these issues.

Resolve boxo update breaking changes
2 participants
@fredcarle @AndrewSisley