fix: Introspection OrderArg returns null inputFields #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasdf
commented
Jul 12, 2023
| map[string]any{ | ||
| "name": "members", | ||
| "type": map[string]any{ | ||
| "name": "", |
There was a problem hiding this comment.
I think this may be the root of the issue. The name should not be empty.
nasdf
changed the title
OrderArg returns null inputFields
Codecov ReportPatch coverage:
@@ Coverage Diff @@
## develop #1633 +/- ##
===========================================
- Coverage 75.61% 75.48% -0.13%
===========================================
Files 199 199
Lines 20774 20769 -5
===========================================
- Hits 15707 15676 -31
- Misses 3992 4009 +17
- Partials 1075 1084 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
) ## Relevant issue(s) Resolves sourcenetwork#1632 Resolves sourcenetwork#1502 Resolves sourcenetwork#1463 ## Description This PR adds an introspection test that identifies an issue with `orderArg`. ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? `make test` Specify the platform(s) on which this was tested: - MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1632
Resolves #1502
Resolves #1463
Description
This PR adds an introspection test that identifies an issue with
orderArg.Tasks
How has this been tested?
make testSpecify the platform(s) on which this was tested: