refactor: Reuse lens wasm modules #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/schema
fredcarle
reviewed
Jul 18, 2023
AndrewSisley
force-pushed
the
1640-lens-module-reuse
branch
from
68af1a6
to
4c4e8c9
Compare
Codecov ReportPatch coverage:
@@ Coverage Diff @@
## develop #1641 +/- ##
===========================================
+ Coverage 74.89% 74.92% +0.03%
===========================================
Files 203 203
Lines 21077 21084 +7
===========================================
+ Hits 15784 15796 +12
+ Misses 4212 4209 -3
+ Partials 1081 1079 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Is much much cheaper
AndrewSisley
force-pushed
the
1640-lens-module-reuse
branch
from
1bb33ad
to
1791f90
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1640 ## Description Reuses lens wasm modules to spawn new module instances. Is an awful lot cheaper - I span up 1000 duplicates in defra and the cost was too small for me to bother measuring it properly, might have been 1-3GB (for the 1000 instances) (compared to 20GB or so previously).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1640
Description
Reuses lens wasm modules to spawn new module instances. Is an awful lot cheaper - I span up 1000 duplicates in defra and the cost was too small for me to bother measuring it properly, might have been 1-3GB (for the 1000 instances) (compared to 20GB or so previously).
Draft PR as it currently is pointed at a local path, new Lens code can be found here: lens-vm/lens#50.