test: Add tests for 1-1 group by id #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/query
AndrewSisley
force-pushed
the
1653-group-by-one-one
branch
from
f9f24c4
to
e4162d9
Compare
Codecov ReportPatch coverage has no change and project coverage change:
@@ Coverage Diff @@
## develop #1655 +/- ##
===========================================
- Coverage 74.89% 74.88% -0.01%
===========================================
Files 203 203
Lines 21077 21077
===========================================
- Hits 15784 15782 -2
- Misses 4213 4214 +1
- Partials 1080 1081 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
fredcarle
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
LGTM.
Note: I think @shahzadlone had noted something similar in one of his latest PRs.
AndrewSisley
force-pushed
the
1653-group-by-one-one
branch
from
e4162d9
to
f3b742e
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1653 ## Description Adds tests for 1-1 group by id, documenting a bug (sourcenetwork#1654) in the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1653
Description
Adds tests for 1-1 group by id, documenting a bug (#1654) in the process.