Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible need to properly seed in a deterministic order for benchutils #1690

Open
shahzadlone opened this issue Jul 23, 2023 · 0 comments
Open
Labels
code quality Related to improving code quality meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM

Comments

@shahzadlone
Copy link
Member

The following seeding code was removed in #1689,
Due to https://stackoverflow.com/questions/75597325/rand-seedseed-is-deprecated-how-to-use-newrandnewseed,
In tests/bench/bench_util.go,

	// create a consistent seed value for the random package
	// so we don't have random fluctuations between runs
	// (specifically thinking about the fixture generation stuff)
	seed := hashToInt64("https://xkcd.com/221/")
	rand.Seed(seed)

Discussion: #1689 (comment)

Making issue for traceability incase we want to have determinism again.

@shahzadlone shahzadlone added meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM code quality Related to improving code quality labels Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Related to improving code quality meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM
Projects
None yet
Development

No branches or pull requests

1 participant