fix: Return errors from typeJoinOne #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
force-pushed
the
1711-handle-one-join-errors
branch
from
420a599
to
2c477c1
Compare
fredcarle
reviewed
Jul 26, 2023
planner/type_join.go
Outdated
| } | ||
|
|
||
| // We have to reset the scan node after appending the new key-filter | ||
| if err := n.subType.Init(); err != nil { | ||
| log.ErrorE(n.p.ctx, "Sub-type initialization error at scan node reset", err) | ||
| return doc | ||
| return doc, errors.Wrap("sub-type initialization error at scan node reset", err) |
fredcarle
reviewed
Jul 26, 2023
planner/type_join.go
Outdated
| @@ -408,8 +413,7 @@ func (n *typeJoinOne) valuesPrimary(doc core.Doc) core.Doc { | |||
|
|
|||
| // re-initialize the sub type plan | |||
| if err := n.subType.Init(); err != nil { | |||
| log.ErrorE(n.p.ctx, "Sub-type initialization error at scan node reset", err) | |||
| return doc | |||
| return doc, errors.Wrap("sub-type initialization error at scan node reset", err) | |||
There was a problem hiding this comment.
todo: After adding the above to errors.go, you can use the defined error function here :)
fredcarle
approved these changes
Jul 26, 2023
Codecov ReportPatch coverage:
@@ Coverage Diff @@
## develop #1716 +/- ##
===========================================
+ Coverage 75.37% 75.38% +0.01%
===========================================
Files 208 208
Lines 21717 21719 +2
===========================================
+ Hits 16369 16372 +3
+ Misses 4207 4206 -1
Partials 1141 1141
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1711 ## Description Returns errors from typeJoinOne instead of ignoring them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1711
Description
Returns errors from typeJoinOne instead of ignoring them.
I assume this is a historical accident.