Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i): Update go-libp2p to 0.29.2 #1780

Merged

Conversation

fredcarle
Copy link
Collaborator

@fredcarle fredcarle commented Aug 11, 2023

Relevant issue(s)

Resolves #1779

Description

This PR updates go-libp2p to 0.29.1

@fredcarle fredcarle requested a review from a team August 11, 2023 20:27
@fredcarle fredcarle self-assigned this Aug 11, 2023
@fredcarle fredcarle added the dependencies Related to dependencies label Aug 11, 2023
@fredcarle fredcarle added this to the DefraDB v0.7 milestone Aug 11, 2023
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but would suggest instead bumping it to 0.29.2, or dependebot will just add another PR to merge

@fredcarle
Copy link
Collaborator Author

Approving, but would suggest instead bumping it to 0.29.2, or dependebot will just add another PR to merge

Oh good point!

@fredcarle fredcarle force-pushed the fredcarle/chore/update-libp2p branch from c79b542 to 6506d38 Compare August 11, 2023 20:30
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (359e949) 75.84% compared to head (6506d38) 75.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1780      +/-   ##
===========================================
- Coverage    75.84%   75.81%   -0.04%     
===========================================
  Files          209      209              
  Lines        22064    22064              
===========================================
- Hits         16734    16726       -8     
- Misses        4183     4189       +6     
- Partials      1147     1149       +2     
Flag Coverage Δ
all-tests 75.81% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359e949...6506d38. Read the comment docs.

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update the title to reflect the new version bumping to.

@fredcarle fredcarle changed the title chore(i): Update go-libp2p to 0.29.1 chore(i): Update go-libp2p to 0.29.2 Aug 11, 2023
@fredcarle fredcarle merged commit 23a633e into sourcenetwork:develop Aug 11, 2023
13 checks passed
@fredcarle fredcarle deleted the fredcarle/chore/update-libp2p branch August 11, 2023 20:47
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#1779 

## Description

This PR updates go-libp2p to 0.29.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump libp2p-go to v0.29.2
3 participants