Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(i): Add tests for multiple one-one joins #1793

Merged

Conversation

AndrewSisley
Copy link
Contributor

@AndrewSisley AndrewSisley commented Aug 15, 2023

Relevant issue(s)

Resolves #1792

Description

Adds tests for multiple one-one joins.

@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite code quality Related to improving code quality action/no-benchmark Skips the action that runs the benchmark. labels Aug 15, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.7 milestone Aug 15, 2023
@AndrewSisley AndrewSisley requested a review from a team August 15, 2023 21:01
@AndrewSisley AndrewSisley self-assigned this Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04% 🎉

Comparison is base (1cb993d) 75.69% compared to head (1fe9614) 75.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1793      +/-   ##
===========================================
+ Coverage    75.69%   75.72%   +0.04%     
===========================================
  Files          209      209              
  Lines        22213    22213              
===========================================
+ Hits         16812    16820       +8     
+ Misses        4233     4228       -5     
+ Partials      1168     1165       -3     
Flag Coverage Δ
all-tests 75.72% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb993d...1fe9614. Read the comment docs.

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these Andy :)

@AndrewSisley AndrewSisley force-pushed the 1792-one-one-multiple-tests branch 2 times, most recently from 6936719 to 3aa4417 Compare August 15, 2023 22:13
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers LGTM

@AndrewSisley AndrewSisley merged commit e21dfe7 into sourcenetwork:develop Aug 15, 2023
12 checks passed
@AndrewSisley AndrewSisley deleted the 1792-one-one-multiple-tests branch August 15, 2023 22:49
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#1792 

## Description

Adds tests for multiple one-one joins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test gap: No tests for multiple one-one joins from object
3 participants