ci: Add mac test runner

[AndrewSisley]

Relevant issue(s)

Resolves #2034

Description

Adds a mac (latest) test run to our test matrix.

This only use the lightest of configurations we have, I think this will catch any/99% issues that we would otherwise miss.

Windows has been broken out to a different ticket, as quite a lot of tests fail on windows and it will take more effort to get working: #2033

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ff01cd) 73.85% compared to head (64a3700) 73.86%.
Report is 1 commits behind head on develop.

@@             Coverage Diff             @@
##           develop    #2035      +/-   ##
===========================================
+ Coverage    73.85%   73.86%   +0.01%     
===========================================
  Files          248      248              
  Lines        24801    24801              
===========================================
+ Hits         18315    18318       +3     
+ Misses        5224     5222       -2     
+ Partials      1262     1261       -1     

Flag	Coverage Δ
all-tests	73.86% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c490de...64a3700. Read the comment docs.

[shahzadlone]

thought: Perhaps an additional check on line 83, where coverage reports are uploaded within step.name: Upload coverage artifact and line 75 within step.name: Run integration tests so that we don't generate and don't upload code coverage reports for the same type of test twice (as a ubuntu variant will already have had been uploaded by other run), and skip it for macos and windows like we do for change detection? Then you would need to update the steps.name: Run change detector tests condition (line 79) to allow macos test.

If you do the above, would suggest renaming the following step names:

1. Rename "Run integration tests" -> "Run tests with coverage"
2. Rename "Run change detector tests" -> "Run tests without coverage"

Other than that rest LGTM! now all we need to do is update these 19 required matrix jobs lol with 20 new ones haha:

[shahzadlone]

@AndrewSisley

Once ready to merge, LMK I can remove the previous required checks.

[shahzadlone]

thought(out of scope): While you are at it, perhaps an explicit fail-fast: true (which is the default behavior at the moment). To have it stay consistent incase GitHub decides to change the default in the future.

[AndrewSisley]

@shahzadlone

Perhaps an additional check on line 83 (not uploading code-cov)

I do disagree with this, and I do want mac/windows to contribute to the code cov upload. They may test OS specific lines, and the cost to including them should be tiny. If the windows run turns out to be significantly slower and the primary bottleneck we can revisit, but even then I would be hesitant to support excluding it.

[shahzadlone]

I do disagree with this, and I do want mac/windows to contribute to the code cov upload. They may test OS specific lines, and the cost to including them should be tiny. If the windows run turns out to be significantly slower and the primary bottleneck we can revisit, but even then I would be hesitant to support excluding it.

I can vibe with that.