chore: Update dependencies #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
force-pushed
the
fredcarle/chore/update-dependencies
branch
from
6c96e23
to
ebf354e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## develop #2044 +/- ##
===========================================
+ Coverage 73.78% 73.87% +0.09%
===========================================
Files 248 248
Lines 24801 24801
===========================================
+ Hits 18297 18320 +23
+ Misses 5237 5220 -17
+ Partials 1267 1261 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Since libp2p/go-libp2p#2560, `0.0.0.0` is no longer valid as a peer connection address. This is causing issues for our tests so we change the IP to `127.0.0.1`.
fredcarle
force-pushed
the
fredcarle/chore/update-dependencies
branch
from
ebf354e
to
97fdea2
Compare
fredcarle
force-pushed
the
fredcarle/chore/update-dependencies
branch
from
97fdea2
to
a901e85
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#2043 ## Description This PR updates go dependencies that couldn't be done by dependabot for different reasons. One of which is the result of deprecating `libpeer.ID.Pretty` from `libp2p`. An [update](libp2p/go-libp2p#2560) to `libp2p` also made it no longer valid to connect to a peer on `0.0.0.0`. We now need to use `127.0.0.1` for our tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2043
Description
This PR updates go dependencies that couldn't be done by dependabot for different reasons. One of which is the result of deprecating
libpeer.ID.Prettyfromlibp2p.An update to
libp2palso made it no longer valid to connect to a peer on0.0.0.0. We now need to use127.0.0.1for our tests.Tasks
How has this been tested?
Make test
Specify the platform(s) on which this was tested: