Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: changelog v0.2.1 #252

Merged
merged 6 commits into from Mar 4, 2022
Merged

chore: changelog v0.2.1 #252

merged 6 commits into from Mar 4, 2022

Conversation

orpheuslummis
Copy link
Contributor

To be updated, then to be merged as the last commit on the release.
Closes #251

@orpheuslummis orpheuslummis added the meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM label Mar 1, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.2.1 milestone Mar 1, 2022
@orpheuslummis orpheuslummis self-assigned this Mar 1, 2022
@orpheuslummis orpheuslummis marked this pull request as draft March 2, 2022 13:07
@jsimnz jsimnz changed the base branch from develop to release/0.2.1 March 4, 2022 09:11
@jsimnz jsimnz added the release Related to release cycle label Mar 4, 2022
@orpheuslummis orpheuslummis force-pushed the orpheus/chore/changelog-v0.2.1 branch from aba3eb1 to 081cb49 Compare March 4, 2022 18:10
@orpheuslummis orpheuslummis force-pushed the orpheus/chore/changelog-v0.2.1 branch from 081cb49 to 06564f9 Compare March 4, 2022 18:57
@orpheuslummis orpheuslummis marked this pull request as ready for review March 4, 2022 19:19
jsimnz
jsimnz reviewed Mar 4, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jsimnz
Copy link
Member

jsimnz commented Mar 4, 2022

Updated the base release branch, so you'll prob need to regenerate the changelog then make the above changes for the logging PRs

@jsimnz
Copy link
Member

jsimnz commented Mar 4, 2022

There was also 1-2 PRs that got merged without prefix's let me find them.

@jsimnz
Copy link
Member

jsimnz commented Mar 4, 2022

Looks like its only 07a71a4.

So lets manually add this too

@jsimnz jsimnz self-requested a review March 4, 2022 20:17
jsimnz
jsimnz requested changes Mar 4, 2022
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@jsimnz
Copy link
Member

jsimnz commented Mar 4, 2022 •
edited by orpheuslummis

Updated the base release branch, so you'll prob need to regenerate the changelog then make the above changes for the logging PRs

Actually, since you already rebased you PR, it should be fine. No need to regenerate. Just add the two mentioned changes.

  • Combine logging PRs
  • Add PR with missing prefix.

jsimnz
jsimnz approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@orpheuslummis orpheuslummis merged commit b6941f6 into release/0.2.1 Mar 4, 2022
@orpheuslummis orpheuslummis deleted the orpheus/chore/changelog-v0.2.1 branch March 4, 2022 21:11
jsimnz pushed a commit that referenced this pull request Mar 6, 2022
@orpheuslummis @jsimnz
chore: Update changelog v0.2.1 (#252)
3d76533
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
chore: Update changelog v0.2.1 (sourcenetwork#252)
ed1fda5
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis @jsimnz
chore: Update changelog v0.2.1 (sourcenetwork#252)
5e96dbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsimnz jsimnz jsimnz approved these changes

Assignees

@orpheuslummis orpheuslummis

Labels
meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM release Related to release cycle
Projects
None yet
Milestone
DefraDB v0.2.1
Development

Successfully merging this pull request may close these issues.

Changelog v0.2.1
2 participants
@orpheuslummis @jsimnz