Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make latest commits syntax sugar #890

Merged
merged 2 commits into from Oct 12, 2022

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #842

Description

Makes latest commits syntax sugar around commits using the new depth param.

@AndrewSisley AndrewSisley added area/query Related to the query component refactor This issue specific to or requires *notable* refactoring of existing codebases and components action/no-benchmark Skips the action that runs the benchmark. labels Oct 12, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.4 milestone Oct 12, 2022
@AndrewSisley AndrewSisley requested a review from a team October 12, 2022 19:42
@AndrewSisley AndrewSisley self-assigned this Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #890 (a437949) into develop (8f57a7f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #890      +/-   ##
===========================================
- Coverage    59.80%   59.79%   -0.02%     
===========================================
  Files          157      157              
  Lines        17452    17423      -29     
===========================================
- Hits         10438    10418      -20     
+ Misses        6071     6065       -6     
+ Partials       943      940       -3     
Impacted Files Coverage Δ
query/graphql/mapper/commitSelect.go 0.00% <ø> (ø)
query/graphql/mapper/mapper.go 85.18% <ø> (-0.02%) ⬇️
query/graphql/planner/select.go 77.35% <ø> (+0.11%) ⬆️
query/graphql/parser/commit.go 80.21% <100.00%> (+4.63%) ⬆️
query/graphql/planner/commit.go 91.01% <100.00%> (-0.52%) ⬇️
query/graphql/planner/dagscan.go 75.49% <100.00%> (ø)
events/simple.go 86.76% <0.00%> (+2.94%) ⬆️

Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AndrewSisley AndrewSisley merged commit 2ee445e into develop Oct 12, 2022
@AndrewSisley AndrewSisley deleted the sisley/refactor/I842-latest-commits-sugar-2 branch October 12, 2022 19:58
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
* Make latestCommits syntax sugar around commits

* Remove commit-type related code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/query Related to the query component refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commits: Rework latest_commits so it is syntax sugar only
2 participants