Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hall of fame should filter bot/app accounts #22

Closed
chris48s opened this issue Aug 30, 2018 · 1 comment
Closed

hall of fame should filter bot/app accounts #22

chris48s opened this issue Aug 30, 2018 · 1 comment

Comments

@chris48s
Copy link

chris48s commented Aug 30, 2018 •
edited

If I generate a hall of fame for this repo https://github.com/badges/shields

dependabot is included as a contributor:

hof2

(additionally, the link it generates for the bot's "profile" is https://github.com/dependabot[bot] which is a 404. If anything it should be https://github.com/apps/dependabot )

However, I think if it is possible to identify activity from github app/bot accounts these should ideally be excluded in favour of human contributors.
@sergey48k
Copy link
Member

sergey48k commented Aug 31, 2018 •
edited

Added a fix and released to production: 4ef1aa9

01234567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chris48s @sergey48k