Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can we remove the Sourcery Quality reports? #329

Closed
joamatab opened this issue Mar 28, 2023 · 3 comments
Closed

How can we remove the Sourcery Quality reports? #329

joamatab opened this issue Mar 28, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@joamatab
Copy link

How can we remove the Sourcery Quality reports

I love sourcery and is great to send PRs to automatically refactor the code, it has improved the quality of my code since I started using it

one issue i find is that the Source quality reports are quite long and discourage PR conversations, see for example

gdsfactory/gdsfactory#1496

@joamatab joamatab added the enhancement New feature or request label Mar 28, 2023
@reka
Copy link
Contributor

reka commented Mar 29, 2023

Hey,

Thanks a lot for this useful feedback. 👍 I can absolutely understand why the quality report feels annoying. 🙂

I haven't found a way so far to remove it. We'll probably add this option in the next version.

Cheers,
Reka

@reka
Copy link
Contributor

reka commented Mar 31, 2023

Thanks again for this great suggestion. 👍

After some internal discussion, we've removed the Sourcery Code Quality Report from the GitHub bot.
Starting with this morning, you shouldn't see it in your new PRs anymore.

@joamatab
Copy link
Author

Hi Reka,

great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants