Add key and verifyChain connection options #40
Conversation
|
Hi, just checking to see if this can be merged? |
|
@mitch-roblox right now you have two conflicts so you'll have to rebase against master for us to consider merging this. |
mitch-roblox
force-pushed
the
feature/connection_opts
branch
from
3193f6b
to
6d0ad1c
Compare
|
Hi, I rebased this against master and now it's passing the tests. Please let me know if there is anything else you need from me. Thanks! |
|
@martinisoft Hi, just checking in on this. Thanks! |
templates/default/stunnel.conf.erb
Outdated
| @@ -99,4 +99,7 @@ TIMEOUTclose = <%= opts['timeout_close'] ? 1 : 0 %> | |||
| <% unless opts['client'].nil? -%> | |||
| client = <%= opts['client'] ? "yes" : "no" %> | |||
| <% end -%> | |||
| <% unless opts['verify_chain'].nil? %> | |||
There was a problem hiding this comment.
Little nitpick, but I'd like you to add the whitespace chomp at the end of the tag like the other unless blocks for consistency. At the end change %> to -%> on this line and the end line as well.
mitch-roblox
force-pushed
the
feature/connection_opts
branch
from
6d0ad1c
to
2aefd99
Compare
|
@martinisoft Ah, good catch, thank you! I've pushed up the requested fix. |
|
@martinisoft Hello, just checking in on this. Thank you! |
|
I'll work on merging and shipping this later today. Have a bit of a backlog to work through first. Thank you again for your contribution. ❤️ |
|
Hello, I hate to be a bother, but just checking in on this. Thank you! |
|
@martinisoft Hi, just checking in on this. I would greatly appreciate it if it could be merged soon. Thank you! |
|
Thanks for checking in @mitch-roblox I'll get to a release shortly. On conference wifi so we'll see how well this works. |
|
All merged and shipped. It should be available on the supermarket shortly. 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This adds options for
keyandverifyChainto the per-server settings.