Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Four failing RSpec tests in master branch #365

Closed
gdavison opened this issue Nov 3, 2016 · 2 comments
Closed

Four failing RSpec tests in master branch #365

gdavison opened this issue Nov 3, 2016 · 2 comments

Comments

@gdavison
Copy link
Contributor

gdavison commented Nov 3, 2016

There are four failing RSpec tests in master:

  • rspec ./test/spec/recipes/default_spec.rb:30 # consul::default with create_service_user disabled does not try to create the user
  • rspec ./test/spec/libraries/consul_installation_webui_spec.rb:31 # ConsulCookbook::Provider::ConsulInstallationWebui webui installation
  • rspec ./test/spec/libraries/consul_installation_webui_spec.rb:25 # ConsulCookbook::Provider::ConsulInstallationWebui webui installation
  • rspec ./test/spec/libraries/consul_installation_webui_spec.rb:19 # ConsulCookbook::Provider::ConsulInstallationWebui webui installation

This appears to be blocking a number of PRs

@gdavison
Copy link
Contributor Author

gdavison commented Nov 4, 2016

It looks like the WebUI tests have to be marked pending individually, which resolves three of the tests.

For the user test, calling default_attributes does not seem to be passing the attributes to the recipe during the test. I also added some tests in paybyphone@e21f649 to ensure the correct users are being created. It is currently creating the consul user in each case.

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant