Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create consul_directories in install_* recipes #40

Closed
ghost opened this issue Sep 10, 2014 · 2 comments
Closed

Create consul_directories in install_* recipes #40

ghost opened this issue Sep 10, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Sep 10, 2014

What do you think of moving the consul_directories.each block from _service.rb to the install_*.rb recipes? That way, consul::install_binary could be run in an initial setup step, monitored services could be added to that directory, and later on the consul service could be enabled and started in a later step without needing to fuss with creating node['consul']['config_dir'] for every service.

I'd be happy to create a PR if you'd like.

Thanks for this great cookbook regardless!

@reset
Copy link
Contributor

reset commented Sep 10, 2014

@rstrox it's in _service right now because it's common configuration between the two different installation methods. This could easily be refactored into a _common recipe and then included in each of the installation recipes.

I'm having a bit of a hard time understanding the way that you're using the cookbook that the order in which these directories are created is affecting you. Could you try to explain a bit more? Thanks!

@ghost
Copy link
Author

ghost commented Sep 10, 2014

Thanks for the quick reply!

My plan was to install consul early alongside a "base" set of other recipes, populate config_dir with files in later recipes, and then cluster the nodes outside of chef after all the nodes converge.

Is there a recommended workflow for bootstrapping a cluster if one does not already exist, and joining an existing cluster using Chef's search facility or similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants