Fix up name attribute to prevent multiple uses of same resource

[computerlyrik]

I am not sure if i am getting this right....i am new to docker and this cookbook.

I think chef warns about declaring a same-name resource more than once.

If i think about my (future) configuration:

docker_container "some_image" do
command "/run/my/service1"
action :start
end

docker_container "some_image" do
command "/run/my/service2"
action :start
end

chef will send a warning.

Proposal: use the hostname for name_attribute.

[bflad]

That's correct, Chef will warn about using the same resource multiple times. Nicely, it does still work by copying attributes to the second instance, although there's an open ticket CHEF-3694 to possibly remove the functionality.

For now, things work as expected. Example:
https://github.com/bflad/chef-docker/blob/master/test/cookbooks/docker_test/recipes/container_lwrp.rb

I'm willing to discuss this more (bonus points for being able to come up with a workable solution), but also tempted to close this issue since its a what-if scenario in the Chef core that will have huge implications with many other cookbooks if Opscode changes the behavior.

[bflad]

Closing as a non-issue for now since cookbook still works until Opscode introduces the major change and I don't believe its a trivial fix. If anyone has ideas for fixing this, please reopen. Thanks!