Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container remove_volume action is broken by design #182

Closed
jperville opened this issue Jun 30, 2014 · 1 comment
Closed

Container remove_volume action is broken by design #182

jperville opened this issue Jun 30, 2014 · 1 comment

Comments

@jperville
Copy link
Contributor

Opening this issue because after fixing #181 I noticed that the remove_volume action of the docker_container resource is broken in a similar way than links, but unlike the remove_link action it cannot be fixed without changing the documented API, I'd rather have you fix it than me :-)

The problem

The remove_volume action is documented here. It is supposed to remove some volumes (possibly not all) that were exported by a container while that container is being removed.

However, there is (as of 1.0.1) no version of docker rm with such a feature. According to man docker-rm there is a --volumes flag that when set to true will remove all volumes exported by the container while removing that container.

Possible solution

We should remove the remove_volume action of the docker_container resource, and replace it with a --volumes cli flag that would go docker_container action remove, like current the --force cli flag.

@someara
Copy link
Contributor

someara commented Jul 14, 2015

garbage collecting this issue since it seems invalid with modern versions.
re-open if its still a problem

@someara someara closed this as completed Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants