Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dynamic configuration with cookbook configuration? #318

Open
oggy opened this issue Mar 27, 2017 · 2 comments
Open

Merge dynamic configuration with cookbook configuration? #318

oggy opened this issue Mar 27, 2017 · 2 comments
Labels
Feature Request Enhancement to existing functionality or new functionality Help Wanted Assistance is required to resolve this issue Priority: Medium Will bring visible benefit to the project

Comments

@oggy
Copy link

oggy commented Mar 27, 2017

Like others here, I'm finding the breadcrumb mechanism a little unintuitive. Additionally, when using sentinel, it means you can't update the redis configuration after the first chef run without messing with the server state. So I'm wondering: is there a reason the provider can't merge its configuration with what the redis server wrote?

Redis delimits the configuration it writes with a comment: # Generated by CONFIG REWRITE, so the provider could easily append that to the configuration generated by the cookbook. I can submit a patch if this sounds good; just wanted to check if this idea has been considered/dismissed already.

@poloka
Copy link

poloka commented Aug 13, 2018

I'd like to see a fix for the breadcrumb concept. The initial PR missed updating the sentinel recipe so now I'm stuck having to manually delete this breadcrumb file in order to complete my chef run. I tested this out with even setting default['redisio']['default_settings']['breadcrumb'] to false.

@xorima xorima added Feature Request Enhancement to existing functionality or new functionality Help Wanted Assistance is required to resolve this issue Priority: Medium Will bring visible benefit to the project labels May 13, 2019
@github-actions
Copy link

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

@github-actions github-actions bot added the Stale label Sep 30, 2020
@xorimabot xorimabot removed the Stale label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement to existing functionality or new functionality Help Wanted Assistance is required to resolve this issue Priority: Medium Will bring visible benefit to the project
Projects
None yet
Development

No branches or pull requests

6 participants