Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul dependency versioning to support tags, branches and commit hashes #34

Closed
Southclaws opened this issue Nov 22, 2017 · 1 comment
Closed

Overhaul dependency versioning to support tags, branches and commit hashes #34

Southclaws opened this issue Nov 22, 2017 · 1 comment
Milestone
1.6

Comments

@Southclaws
Copy link
Owner

If a depstring defines a commit hash, it should pull that exact commit:

Southclaws/SIF:79d22a1e344b41b0d80a1cef960cb75372524982

And if a project doesn't use semver, it should not throw an error:

pBlueG/SA-MP-MySQL:R41-4
@Southclaws Southclaws added this to the 1.6 milestone Jan 17, 2018
@Southclaws Southclaws changed the title Add support for non-semver dependency versioning and exact commit hash versioning Overhaul dependency versioning to support tags and branches Feb 5, 2018
@Southclaws Southclaws changed the title Overhaul dependency versioning to support tags and branches Overhaul dependency versioning to support tags, branches and commit hashes Feb 5, 2018
@Southclaws
Copy link
Owner Author

This issue now encapsulates branches too. Branches will be addressable via the following notation:

user/library@dev

Tags will use the original notation, but now support any tag not just semver:

user/library:1.2.3
user/library:R41

And exact commit hashes will use:

user/library#79d22a1e344b41b0d80a1cef960cb75372524982

Southclaws added a commit that referenced this issue Feb 5, 2018
@Southclaws
rewritten versioning regex and explode func to support branches and c…
3986eeb 
…ommit syntax for #34 - updated tests and added tests for version meta stringer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
1 participant
@Southclaws