Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in CreateThumbnailModule.java IOException is never thrown #76

Closed
anirudh-antino opened this issue Oct 7, 2022 · 5 comments
Closed
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@anirudh-antino
Copy link

node_modules/react-native-create-thumbnail/android/src/main/java/com/createthumbnail/CreateThumbnailModule.java:194: error: exception IOException is never thrown in body of corresponding try statement
        } catch(IOException e) {
          ^
 try {
            retriever.release();
        } catch(IOException e) { <------- here
            e.printStackTrace();
        }
@anirudh-antino anirudh-antino added the bug Something isn't working label Oct 7, 2022
@canismayorisxl
Copy link

There is a catch already in the parent function just a throws IOException would suffice.

@fukemy
Copy link

fukemy commented Oct 18, 2022

I install v0.16.3 but still got this problem

@john-vuong
Copy link

john-vuong commented Oct 19, 2022

This is the same react-native-cameraroll/react-native-cameraroll#402

Set the compile/target SDK to version 33 (Android 13) to recreate the error.

Thanks!

@souvik-ghosh
Copy link
Owner

node_modules/react-native-create-thumbnail/android/src/main/java/com/createthumbnail/CreateThumbnailModule.java:194: error: exception IOException is never thrown in body of corresponding try statement
        } catch(IOException e) {
          ^
 try {
            retriever.release();
        } catch(IOException e) { <------- here
            e.printStackTrace();
        }

The problem with adding this code is that the library won't work on Android version < 13 anymore. So we planned to support android 13 from v2.0.0 onwards. Currently, it's available as a pre-release v2.0.0-rc.2.

@souvik-ghosh
Copy link
Owner

UPDATE: v2.0.0 has been released with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

5 participants