Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should a notion link parse to normal hyper link? #27

Closed
2nthony opened this issue Mar 13, 2022 · 2 comments
Closed

Should a notion link parse to normal hyper link? #27

2nthony opened this issue Mar 13, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@2nthony
Copy link

2nthony commented Mar 13, 2022

image

I am expect it to be notion.so/{pageid}

case "link_preview":
{
let blockContent;
if (type === "bookmark") blockContent = block.bookmark;
if (type === "embed") blockContent = block.embed;
if (type === "link_preview") blockContent = block.link_preview;
if (blockContent) return md.link(type, blockContent.url);
}
break;

Maybe in this case to handle, if the url starts with notion then transform to notion.so/{pageid}

@souvikinator
Copy link
Owner

souvikinator commented Mar 13, 2022

Hey there,
This sort of URL is used to open the notion page/DB in the notion application installed locally in your device.
Can you be specific on how to reproduce this?

@souvikinator souvikinator added the enhancement New feature or request label Mar 13, 2022
@2nthony
Copy link
Author

2nthony commented Mar 13, 2022

I can't reproduce this. Close this for now 🤔

@2nthony 2nthony closed this as completed Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants