Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour for uploaded images? #55

Closed
ashutoshsaboo opened this issue Nov 12, 2022 · 3 comments · Fixed by #81
Closed

Behaviour for uploaded images? #55

ashutoshsaboo opened this issue Nov 12, 2022 · 3 comments · Fixed by #81
Labels
enhancement New feature or request question Further information is requested

Comments

@ashutoshsaboo
Copy link

ashutoshsaboo commented Nov 12, 2022

I was seeing that for images that are added to Notion via a public url are exported as is with the same url in markdown. For custom/actually uploaded images (non publicly hosted images; from the notion filepicker/drag and drop) to Notion, how does the export work?

Does it extract the image as base64 in markdown? Or how does it work? @souvikinator

@souvikinator
Copy link
Owner

souvikinator commented Dec 19, 2022

As of now the multimedia selected from the file picker or drag and drop, the exact local path gets added.
No, it does not convert the image to base64 as certain markdown parser may not render the image.

@souvikinator
Copy link
Owner

PR #81 address this issue. Expect it to go live in the next major update, along with various bug fixes.

Appreciate everyone's contribution in enhancing the package. 🚀
Thank you.

@ashutoshsaboo
Copy link
Author

Thanks for the update! @souvikinator 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: Done
2 participants