[WiP] Handle exception when fetching catalog data #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulgg
reviewed
Feb 14, 2024
extensions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/UiResourceImpl.java
Show resolved
Hide resolved
.../wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/pages/catalog/CatalogApiService.java
Show resolved
Hide resolved
...pper/src/test/java/de/sovity/edc/ext/wrapper/api/ui/pages/catalog/CatalogApiServiceTest.java
Show resolved
Hide resolved
| val service = new CatalogApiService(mock(AssetMapper.class), mock(PolicyMapper.class), catalogApiService); | ||
|
|
||
| // act | ||
| val exception = assertThrows(WebApplicationException.class, () -> service.fetchDataOffers("http:example.com")); |
There was a problem hiding this comment.
Could be minimized to "http://a"
There was a problem hiding this comment.
Even "" would work, because this is mocked and as long as it gets a string it works.
Does it matter that it be short?
There was a problem hiding this comment.
It's nit but "http://a" is short and shows the input is a URL
and short is nice
| // act | ||
| val exception = assertThrows( | ||
| DspCatalogServiceException.class, | ||
| () -> service.fetchDataOffers("http://example.com")); |
There was a problem hiding this comment.
Could be minimized to "http://a"
ununhexium
changed the title
| return future | ||
| .get() | ||
| .orElseThrow(DspCatalogServiceException::ofFailure); | ||
| } catch (CancellationException | ExecutionException | InterruptedException e) { |
There was a problem hiding this comment.
InterruptedException must always be re-thrown
|
Outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#797
Checklist