Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark icon #8

Closed
tborychowski opened this issue Jul 20, 2018 · 10 comments
Closed

dark icon #8

tborychowski opened this issue Jul 20, 2018 · 10 comments

Comments

@tborychowski
Copy link

The macos mojave dark theme has dark background icons.
Is there a plan to make this one in dark version also?

screenshot 2018-07-20 at 14 18 01

@tborychowski
Copy link
Author

Hi, I made the icon, just don't know how to build it.
It doesn't have to be packed into the single app (containing both light & dark version).
I'd be perfectly happy with 2 separate apps - 1 with light bg and 1 with dark.
Would you be able to build it (or add description to the README how to build it?)

Here's the zip with icon:
vscode-dark.zip

It's hi-res and should be aligned with the rest of the toolbar icons.
Here's how it looks:
vscode_512x512

@mirkolenz
Copy link

The icon looks great, thanks for sharing it!

Until it is implemented by the project owner, you could use the following workaround:

  • Right click onto the app "Open in Code" and select "Get Info".
  • Drag your new dark icon and drop it onto the old application icon in the top left of the inspector window.
  • You should now have the new icon in the Finder menu bar.

Hope it helps.

@tborychowski
Copy link
Author

Thanks @mirkolenz!
I know that trick, but somehow I didn't think of it! 😀
Works perfectly!

@ZaynJarvis
Copy link

Thank you guys for this icon and trick!

@tborychowski
Copy link
Author

tborychowski commented Nov 14, 2018

Updated icon (as it seems that native toolbar buttons are a bit shorter now):
vscode.zip

screenshot 2018-11-14 at 09 59 09

(unfortunately I don't know how to do the same as native active style (when mouse button is down) or make it as sharp as the native)

@sozercan
Copy link
Owner

sozercan commented Dec 5, 2018

thanks so much @tborychowski! I updated the release with the dark mode icon:
https://github.com/sozercan/OpenInCode/releases/download/v1.0/OpenInCodeDark.zip

@sozercan sozercan closed this as completed Dec 5, 2018
@pushqrdx
Copy link

@tborychowski What is that other icon that looks like terminal? 😄

@bbilginn
Copy link

hi @tborychowski, can you also share the svg file for the terminal?
hi @pushqrdx maybe it looks like this https://github.com/es-kumagai/OpenTerminal but icon is good drawn icon
thanks everyone

@tborychowski
Copy link
Author

@pushqrdx @bbilginn, no this was done for open-in-iterm.

I've redone both icons myself (in sketch).
I can share the sketch file if anyone's interested (just send me a @gmail).

@stevemoser
Copy link

How do I use home brew to install the dark version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants