-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FXAA 3.11 in shaders menu #1879
Comments
The FXAA configuration and shaders are in |
It seems that i can't do much due to the lack of bilinear filtering. |
it was due to the lack of bilinear filtering this time it replaces super secret setting's fxaa(1.8.9, click the button twice), and 2x zoom is applied. |
Looks very smooth, but the zoom dependency is strange. |
just found a fix for 1x zoom, turns out that i need to apply half a pixel coordinate shift. here's the result now it replaces 2x again. i can't guarantee if it's artifact free |
The current 2x FXAA uses SubPixelShift in the .vsh:
|
@CaptTatsu can you fix the artifacts (subpixel shift)? |
I just found out that the FXAA used by Optifine and me is kind of old. It creates noticeable artifacts at somewhat detailed texture in distance (i'll use Jappa's oak leaves as the example), and it only does a little bit of smoothing in near horizontal / vertical lines.
I tried using FXAA 3.11 and most of the issues above are resolved. However, it's obviously a bit more expensive and doesn't work in lower render quality (below 1x)
Here's the article which includes somewhat easy to implement FXAA 3.11 here.
Here's some comparison between old FXAA with FXAA 3.11 (using BSL)
![image](https://user-images.githubusercontent.com/38376866/46619884-74f60280-cb4d-11e8-9643-3bde93b2c321.png)
Jappa's oak leaves
(left : old, right : 3.11, more noticeable in darker spots)
Near horizontal line
![image](https://user-images.githubusercontent.com/38376866/46620101-01082a00-cb4e-11e8-9683-1bedc2443112.png)
(top : old, bottom : 3.11)
The text was updated successfully, but these errors were encountered: