-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastMath breaks elytra on OptiFine 1.12.2 F5 #3395
Comments
Can confirm it happens on Windows 10 as well. From what I've been able to determine, the bug was introduced in OptiFine_1.12.2_HD_U_F4. Another way to reproduce the bug is to stand next to a block at head height like this and fly straight up. Your X and Z coordinates are somehow set to NaN. |
I can confirm that this happens on 1.12.2 when I am using the “Fast Maths” option on my client. Edit: happens on Windows, Mac OS and Linux. Edit 2: also happens while playing on my Minecraft server. (Small edit: this bug seems to effect both singleplayer and multiplayer) |
if (f < 0.0F)
{
double d9 = d7 * (double)(-MathHelper.sin(f)) * 0.04D;
assert !Double.isNaN(vec3d.x * d9 / d5);
assert !Double.isNaN(vec3d.z * d9 / d5);
this.motionY += d9 * 3.2D;
this.motionX -= vec3d.x * d9 / d5;
this.motionZ -= vec3d.z * d9 / d5;
} These assertions fail because There is a bug somewhere in this code: protected final Vec3d getVectorForRotation(float yaw, float pitch)
{
float f = MathHelper.cos(-pitch * 0.017453292F - (float)Math.PI);
float f1 = MathHelper.sin(-pitch * 0.017453292F - (float)Math.PI);
float f2 = -MathHelper.cos(-yaw * 0.017453292F);
float f3 = MathHelper.sin(-yaw * 0.017453292F);
} @sp614x May you look into this? Kinda want some fix on that. |
Looking straight up while flying elytra will kick player for "Invalid move player packet received" or glitch arms + legs of player making them disappear.
How to reproduce: 1. Enable Fastmath in performance settings 2. Look up while flying elytra
May be only happening on macOS because only one player reported this on discord before.
vid: https://www.youtube.com/watch?v=JruqdJO1-vs
The text was updated successfully, but these errors were encountered: