Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTM] Property weight does not work #4294

Open
SQwatermark opened this issue Jul 8, 2020 · 3 comments
Open

[CTM] Property weight does not work #4294

SQwatermark opened this issue Jul 8, 2020 · 3 comments

Comments

@SQwatermark
Copy link

Description of Issue

Property weight does not work. Only the path of the properties file can determing whith one to use.

But the document says:

ctm.properties:
(Optional) If multiple properties files match the same block, the highest
weighted one is used. In the event of a tie, the properties filenames are
compared next. The default weight is 0.

weight=<integer>

I read ConnectedProperties.class but infact it doesn't parse the property "weight".

OptiFine Version

preview_OptiFine_1.15.2_HD_U_G1_pre30

@sp614x
Copy link
Owner

sp614x commented Jul 9, 2020

This is correct, the weight property is not checked.

@Cloud7050
Copy link

Cloud7050 commented Oct 4, 2020

On 1.15-pre30, it appears that direct properties filename comparison is not working, but non-negative integer weights will still work.

I have been trying to make my pack work with another pack which does not specify weights. It supposedly defaults to 0, so to work around that I have tried negative weights and prepending my properties file with last-sorted characters (eg pi, z) in my pack, but only adding weight=1 to said other pack was working.

Stumbling upon this issue, I have messed with pathing, putting all my cit/ contents into cit/z/. This did work; the other pack's shallowest cit/foo folder for the texture I was testing with starts with "k", so it should sort alphabetically before cit/z. Perhaps the issue is related to comparing too much of the properties file's path instead of just its filename?

@BrokenDoop
Copy link

Yeah, weight doesn't do anything for me either, trying to get my Crimson Nylium overlay texture to have higher priority than my Sand overlay texture, it only cares about the file names which I don't like. (all my textures and respective properties files have their own sub folder so I could add a letter to the start of the folder name to change its priority but I really don't want to do that.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants