Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise Mode to be any eigenmode, not just frequency eigenmode #5

Open
sp94 opened this issue Sep 19, 2020 · 0 comments
Open

Generalise Mode to be any eigenmode, not just frequency eigenmode #5

sp94 opened this issue Sep 19, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@sp94
Copy link
Owner

sp94 commented Sep 19, 2020

The Mode object returned by solve(solver, k, polarisation) could be generalised

Currently it is assumed to be a frequency eigenmode

Mode(k0::Vector, frequency::Number, data::Vector...)

We should rename frequency to eigval, data to eigvec, and add a label string

Mode(k0::Vector, eigval::Number, eigvec::Vector, label::String, ...)

solve(solver, k, polarisation) could return array of Mode(k0, eigval, eigvec, "Frequency")

wilson_eigen() could return array of Mode(k0, eigval, eigvec, "Wilson loop eigenvalue")

The label field could be used by eg plot_band_diagram to automatically label the y-axis

@sp94 sp94 added the enhancement New feature or request label Sep 19, 2020
@sp94 sp94 added this to the v0.2 milestone Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant