Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV4Play - No error message when trying to download Plus videos with --force-subtitle #1555

Open
Sopor opened this issue Sep 5, 2023 · 1 comment

Comments

@Sopor
Copy link
Contributor

Sopor commented Sep 5, 2023

svtplay-dl versions:

svtplay-dl 4.25

Operating system and Python version:

Windows 10

What is the issue:

If i use -S --force-subtitle on a TV4 Play Plus video i don't get any error message as i do when downloading without --force-subtitle

svtplay-dl.exe -S --force-subtitle -v https://www.tv4play.se/paket/tv4-tier-2?return=%2Fprogram%2F9d2e391133d5e83e83ae%2Fhudson-rex%3Fseason%3Dce58b7797631481202cd
DEBUG [1693874476.0159738] D:\a\svtplay-dl\svtplay-dl\lib\svtplay_dl\utils\getmedia.py/get_media: version: 4.25
DEBUG [1693874476.018942] D:\a\svtplay-dl\svtplay-dl\lib\svtplay_dl\service\__init__.py/__init__: service: tv4play
DEBUG [1693874476.018942] D:\a\svtplay-dl\svtplay-dl\lib\svtplay_dl\utils\http.py/request: HTTP getting 'https://www.tv4play.se/paket/tv4-tier-2?return=%2Fprogram%2F9d2e391133d5e83e83ae%2Fhudson-rex%3Fseason%3Dce58b7797631481202cd'
DEBUG [1693874476.0209606] C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\urllib3\connectionpool.py/_new_conn: Starting new HTTPS connection (1): www.tv4play.se:443
DEBUG [1693874476.5236855] C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\urllib3\connectionpool.py/_make_request: https://www.tv4play.se:443 "GET /paket/tv4-tier-2?return=%2Fprogram%2F9d2e391133d5e83e83ae%2Fhudson-rex%3Fseason%3Dce58b7797631481202cd HTTP/1.1" 200 None
DEBUG [1693874476.5511584] D:\a\svtplay-dl\svtplay-dl\lib\svtplay_dl\utils\http.py/request: HTTP getting 'https://avod-auth-alb.a2d.tv/oauth/authorize'
DEBUG [1693874476.5551474] C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\urllib3\connectionpool.py/_new_conn: Starting new HTTPS connection (1): avod-auth-alb.a2d.tv:443
DEBUG [1693874476.8378088] C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\urllib3\connectionpool.py/_make_request: https://avod-auth-alb.a2d.tv:443 "POST /oauth/authorize HTTP/1.1" 200 1095
``

This is what i get without --force-subtitle: ERROR: No videos found. Cant find video id for the video

Some kind of message would have been nice or maybe even a message that this video need a plus account instead of only
Cant find video id for the video (btw, shouldn't Cant be spelled Can't?).

@spaam
Copy link
Owner

spaam commented Sep 5, 2023

yeah that is an issue. i guess its just because the conditions where we do the check is at a different place .)

sure it should be spelled like that. it will be fixed next time we have a update for the service. patch welcome to fix it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants