New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --format
flag to spago docs
#299
Conversation
9b3f54b
to
a2d22f3
Compare
a2d22f3
to
1f1ec8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 馃憦
@f-f Awesome, I just need to do a bit more work to specify an output file when you choose |
@f-f Actually, a question - in PureScript 0.13 the compiler will output HTML and MD to a What do you think is best for Spago to support? The defaults in 0.13 are fine, I think, but for anyone using 0.12 the stdout dump isn't going to be very useful (you can't even do |
@elliotdavies great point. Since we're still in 0.x of both Spago and Purs let's not worry too much about old Purs versions (i.e. it's fine unless we break them, which doesn't seem the case). So I'd say let's go with 0.13 defaults |
@f-f OK! In that case I think this is ready to review 馃槃 |
Thank you @elliotdavies! 馃檪 |
Description of the change
Add a flag to
spago docs
to support different documentation formats. Fixes #294.Running
stack test
onmaster
seems to lead to about half the tests failing, so I can't verify that these changes haven't broken them further.Checklist:
README
P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 馃槉