Incorrect use of source in docker images

[Bckempa]

Discussed in #106

Several Dockerfiles source colcon workspace over/underlays in ways that don't impact the environment of any commands, these are no-ops at best and potentially causing undesired behavior.

docker/space_robots/Dockerfile

Lines 81 to 82 in 76cd412

	&& /bin/bash -c 'source "${SPACEROS_DIR}/install/setup.bash"' \
	&& /bin/bash -c 'source "${MOVEIT2_DIR}/install/setup.bash"' \

[ivanperez-keera]

@Bckempa in case you don't know, you have an option to convert a discussion into an issue. That way, you don't need to link to the prior discussion and all necessary context is included.

[Bckempa]

@Bckempa in case you don't know, you have an option to convert a discussion into an issue. That way, you don't need to link to the prior discussion and all necessary context is included.

That's how I opened this issue, did you expect it to close the corresponding discussion like it does when you convert the other direction?

[ivanperez-keera]

My bad. I thought it would "convert" like it does in the opposite direction, but it creates a separate issue and leaves the discussion open. Github is weird.