Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider porting merge-repos.rb to remove Ruby dependency #108

Open
Bckempa opened this issue Nov 2, 2023 · 4 comments
Open

Consider porting merge-repos.rb to remove Ruby dependency #108

Bckempa opened this issue Nov 2, 2023 · 4 comments
Labels
release followup Issues discovered during release

Comments

@Bckempa
Copy link

Bckempa commented Nov 2, 2023

Moving the merge-repos.rb script to shell or python would reduce the number of system dependencies required to build space-ros

@Bckempa Bckempa added the release followup Issues discovered during release label Nov 2, 2023
@EzraBrooks
Copy link
Member

Personally, pro-Python. shell scripts are slightly more portable but way harder to write good/safe code in. Anywhere that we introduce Python code, though, we should introduce a sane linter configuration.

@Bckempa
Copy link
Author

Bckempa commented Nov 6, 2023

Personally, pro-Python. shell scripts are slightly more portable but way harder to write good/safe code in. Anywhere that we introduce Python code, though, we should introduce a sane linter configuration.

I try not to add Python as a dependency to things just to avoid writing proper shell scripts but since it is expected by other ROS tooling I agree it would be fine.

@EzraBrooks
Copy link
Member

Is there any Linux distro that doesn't include Python? half of them use Python in things like.. their package manager.

@Bckempa
Copy link
Author

Bckempa commented Nov 6, 2023

In my pervious work it's been more about avoiding XKCD Python Environment situations, especially when every [bistro][autocorrect for distro, but I'm leaving it] was in a different phase of the Python 2 to 3 migration using different naming and pathing, etc. on top of supporting people running whatever ancient version of Red Hat they had a license for.

But I agree that Space ROS targets such a narrowly defined and modern platform configuration that none of that caution applies here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release followup Issues discovered during release
Projects
Status: No status
Development

No branches or pull requests

2 participants