Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to proceed with code conformance fixes upstream #73

Open
Tracked by #71
roncapat opened this issue Jun 9, 2023 · 2 comments
Open
Tracked by #71

How to proceed with code conformance fixes upstream #73

roncapat opened this issue Jun 9, 2023 · 2 comments
Assignees

Comments

@roncapat
Copy link

roncapat commented Jun 9, 2023

Simple question, but I think we may establish a standard approach on this (unless there isn't one already and I missed it).

Take as an example: #7

How to proceed upstream? I propose by issuing PRs with a sort of Space ROS standard text like:

SpaceROS Code Conformance

This PR addresses a code conformance issue detected by Space ROS code analysis tools.

Tool: eg. clang-tidy
Issue: eg. default arguments on virtual methods
Full (SARIF?) output:
....

...and then from #7 add a post referencing the opened PR for tracking purposes?

Since there are many things to fix upstream, I think we need an easy way to track the PRs and from time to time step over all the still to-be-merged ones to check if further support/info is needed upstream or simply to kindly trigger the maintainers.

We may expand on this in sort of CONTRIBUTING.md file to be linked on top of each meta-issue like #7.

@EzraBrooks
Copy link
Member

Action item from July 27 meeting: document standard processes with templates, etc. for code conformance PRs upstream

@EzraBrooks EzraBrooks self-assigned this Jul 27, 2023
@roncapat
Copy link
Author

Since I have not been able to join the meeting, is there some additional feedback / something on which you could expand a bit? how may I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants