Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pQuery deprecated in PHP 8.x #74

Open
bngmnn opened this issue Apr 25, 2024 · 2 comments
Open

pQuery deprecated in PHP 8.x #74

bngmnn opened this issue Apr 25, 2024 · 2 comments

Comments

@bngmnn
Copy link

bngmnn commented Apr 25, 2024

There is an "issue" with pQuery being deprecated in PHP 8.1.
Since the package hasn't been updated since 2016, maybe one could consider to replace pQuery with something which experiences updates regularly. I found DiDom for that case, which could be nice to work with instead.

Actually the issue is only deprecated warnings in Wordpress, though.

@bngmnn bngmnn changed the title pQuery deprecated in P pQuery deprecated in PHP 8.x Apr 25, 2024
@bngmnn
Copy link
Author

bngmnn commented Apr 25, 2024

solved in PR #75

@bngmnn bngmnn closed this as completed Apr 25, 2024
@bngmnn bngmnn reopened this Apr 25, 2024
@guyavatrade
Copy link

Maybe a better solution would be just adding the types to pQuery fucntions without changing the logic.
The author can create a fork to the pQuery library like I did.
Solved in PR #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants