Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing error types for QuicTransport methods #2481

Closed
julianbraha opened this issue May 13, 2024 · 0 comments · Fixed by #2482
Closed

Missing error types for QuicTransport methods #2481

julianbraha opened this issue May 13, 2024 · 0 comments · Fixed by #2482
Labels
kind/bug Something isn't working status/needs-triage

Comments

@julianbraha
Copy link
Contributor

Describe the bug

QuicTransport's methods return strings as errors, and have some TODOs to improve the error handling:

  1. // TODO: Error type here
  2. // TODO: Proper error type

Reproduction

No response

Expected behavior

No response

Platform and versions

9.1.0
cargo 1.78.0 (54d8815d0 2024-03-26)
rustc 1.78.0 (9b00956e5 2024-04-29)

Stack trace

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working status/needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

p2p: improve error handling for QuicTransport julianbraha/spacedrive
1 participant
@julianbraha