Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings wont save #12

Closed
jLynx opened this issue Nov 11, 2019 · 4 comments
Closed

Settings wont save #12

jLynx opened this issue Nov 11, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@jLynx
Copy link
Collaborator

jLynx commented Nov 11, 2019

EEPROM does not seem to be working as any setting I change are not saved
@jLynx jLynx added the bug Something isn't working label Nov 11, 2019
@jLynx
Copy link
Collaborator Author

jLynx commented Nov 11, 2019 •
edited

Its resetting because data.magic_num != SETTINGS_MAGIC_NUM

When I read the values out, I get
data.magic_num: 0
SETTINGS_MAGIC_NUM: 1234567891

So for some reason it wont save, even when I call save()

@jLynx
Copy link
Collaborator Author

jLynx commented Nov 11, 2019

Found the issue. eeprom::begin(); was never being called. I will create a PR and close this when done

@jLynx
Copy link
Collaborator Author

jLynx commented Nov 11, 2019

Fixed in #13

@jLynx
Copy link
Collaborator Author

jLynx commented Nov 12, 2019

Merged

@jLynx jLynx closed this as completed Nov 12, 2019
@spacehuhn spacehuhn changed the title [Bug] Settings wont save Settings wont save Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jLynx