Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong smesher ID for rewards #68

Closed
brunovale91 opened this issue Aug 21, 2023 · 0 comments · Fixed by #94
Closed

Wrong smesher ID for rewards #68

brunovale91 opened this issue Aug 21, 2023 · 0 comments · Fixed by #94

Comments

@brunovale91
Copy link

The wrong smesher id is shown for rewards.

This bug happens when there are multiple activations for the same coinbase.

One possible solution is to get the specific activation for the reward when parsing the block.

The block has that info: activation id on AnyRewards.

Still this is not perfect, is not efficient to check the activation to fetch the smesher id for each reward and in case in multiple smesher ids of the same coinbase receive rewards for the same block is not possible to distinguish between them.

A better solution would be to add smesher id to the reward table on the chain state.

Best Regards,

Bruno Vale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant