Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activation: bind post data to genesis id #3507

Closed
dshulyak opened this issue Aug 27, 2022 · 4 comments
Closed

activation: bind post data to genesis id #3507

dshulyak opened this issue Aug 27, 2022 · 4 comments
Assignees

Comments

@dshulyak
Copy link
Contributor

dshulyak commented Aug 27, 2022

part of: spacemeshos/pm#135
depends on: #3505

this can be implemented independently from spacemeshos/pm#168

  • initialize PostSetupManager with genesis id. when imgr.id is passed to Initiliazer and Prover prefix it with genesis id
  • initialize Validator with genesis id. prefix miner id with genesis id when ValidatePost is called

@moshababo could you please review this task?

@moshababo
Copy link
Contributor

Currently, gpu-post doesn't support id size other than 32 bytes. So we need to change that, or let id be the hash of genesis ID and miner ID.

Besides that, LGTM.

@lrettig
Copy link
Member

lrettig commented Sep 5, 2022

My understanding was that POPS-VRF (spacemeshos/pm#168) would achieve this. @dshulyak is the idea here that this is a stopgap until that is done? Or do you think we need both for some reason?

@dshulyak
Copy link
Contributor Author

dshulyak commented Sep 6, 2022

the way pops-vrf described in spacemeshos/pm#168 allows to generate post data in advance. i don't recall the motivation, but i asked on the last call if we can reuse post data between networks and the answer was no.

@moshababo
Copy link
Contributor

Closing in favor of spacemeshos/pm#172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants