Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go fmt test to travis #448

Closed
almogdepaz opened this issue Jan 15, 2019 · 0 comments
Closed

Add go fmt test to travis #448

almogdepaz opened this issue Jan 15, 2019 · 0 comments
Assignees

Comments

@almogdepaz
Copy link
Contributor

almogdepaz commented Jan 15, 2019

Overview / Motivation

we want to keep the project formatted

The Task

run go fmt on all the project
add a test to travis that validates that the whole project is formatted
fix lint test already in travis

Contribution Guidelines

Important: Issue assignment to developers will be by the order of their application and proficiency level according to the tasks complexity. We will not assign tasks to developers who have'nt introduced themselves on our Gitter dev channel

  1. Introduce yourself on go-spacemesh dev chat channel - ask our team any question you may have about this task
  2. Fork branch develop to your own repo and work in your repo
  3. You must document all methods, enums and types with godoc comments
  4. You must write go unit tests for all types and methods when submitting a component, and integration tests if you submit a feature
  5. When ready for code review, submit a PR from your repo back to branch develop
  6. Attach relevant issue to PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants