New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding events in key places #546
Conversation
mesh/block.go
Outdated
@@ -36,6 +36,18 @@ type SerializableTransaction struct { | |||
Payload []byte | |||
} | |||
|
|||
func (t *SerializableTransaction) GetAmount() *big.Int { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amount
is better
state/processor.go
Outdated
if err != nil { | ||
tp.Log.Error("db write error %v", err) | ||
return failed, err | ||
} | ||
|
||
tp.Log.Info("new state root for layer %v is %x", layer, newHash) | ||
tp.Log.With().Info("new state", log.Uint32("layer id", uint32(layer)), log.String("root hash", newHash.String())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layer id
and root hash
will be used as json keys. it is less recommended that they have space. replace with _
state/processor.go
Outdated
if err != nil { | ||
panic("cannot revert- improper state") | ||
} | ||
tp.Log.Info("reverted, new root %x", newState.IntermediateRoot(false)) | ||
tp.Log.With().Info("reverted", log.String("root hash", newState.IntermediateRoot(false).String())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace space here also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All your added log lines are at the Info
level. is this the right level ? info is shown in all of our current setup.
consider downgrading to debug. (will be shown when debug mode is on)
No description provided.