Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use canonical crypto/ed25519 everywhere #35

Closed
lrettig opened this issue Apr 13, 2023 · 0 comments · Fixed by #36
Closed

use canonical crypto/ed25519 everywhere #35

lrettig opened this issue Apr 13, 2023 · 0 comments · Fixed by #36
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lrettig
Copy link
Member

lrettig commented Apr 13, 2023 

          for a future PR: we are now using canonical `crypto/ed25519` everywhere in go-spacemesh. The `ed25519-recovery` library is not used any more.

It looks like its only used for tests in smcli, so its not urgent to remove it 🙂

Originally posted by @fasmat in #34 (comment)
@lrettig lrettig mentioned this issue Apr 13, 2023
Merged
@lrettig lrettig added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 13, 2023
@vavrajosef vavrajosef mentioned this issue Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

recovery import removed vavrajosef/smcli
1 participant
@lrettig