node version is not show using .node-version file from a project

[vschoener]

Current behavior

I use prezto and I installed nodenv and your prompt and when I go inside a node project containing the .node-version, the node version is not showing up, but, if I use nvm use, it works and display the version.

I checked the node version was properly changed by the shims, and it works when I use node -v.

Maybe I miss something during the install from nodenv, prezto module or your prompt, let me know.

Expected behavior

I expect to have the node version displayed when using a .node-version file

Relevant Zsh configuration (.zshrc)

#
# Executes commands at the start of an interactive session.
#
# Authors:
#   Sorin Ionescu <sorin.ionescu@gmail.com>
#

# Source Prezto.
if [[ -s "${ZDOTDIR:-$HOME}/.zprezto/init.zsh" ]]; then
  source "${ZDOTDIR:-$HOME}/.zprezto/init.zsh"
fi

# Customize to your needs...

export NESTOR_CONFIG_PATH=/Users/vincentschoener/work/nestor-config
export NPM_TOKEN=secret
#export NVM_SYMLINK_CURRENT=true
export NESTOR_K8S_HTTP_PROXY="secret:port"
alias kubectl="HTTP_PROXY=secret-proxy kubectl"

#if [ $commands[kubectl] ]; then
#  source <(kubectl completion zsh)
#fi

#prompt pure

#export NVM_DIR="$HOME/.nvm"
#[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
#[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

# The next line updates PATH for the Google Cloud SDK.
if [ -f '/Users/vincentschoener/exec -l /bin/zsh/google-cloud-sdk/path.zsh.inc' ]; then . '/Users/vincentschoener/exec -l /bin/zsh/google-cloud-sdk/path.zsh.inc'; fi

# The next line enables shell command completion for gcloud.
if [ -f '/Users/vincentschoener/exec -l /bin/zsh/google-cloud-sdk/completion.zsh.inc' ]; then . '/Users/vincentschoener/exec -l /bin/zsh/google-cloud-sdk/completion.zsh.inc'; fi

bindkey "^A" vi-beginning-of-line
bindkey "^E" vi-end-of-line

eval "$(nodenv init -)"

SPACESHIP_PROMPT_ORDER=(
  time          # Time stamps section
  user          # Username section
  dir           # Current directory section
  git           # Git section (git_branch + git_status)
  node          # Node.js section
  golang        # Go section
  exec_time     # Execution time
  line_sep      # Line break
  jobs          # Background jobs indicator
  exit_code     # Exit code section
  char          # Prompt character
)

Environment

Spaceship version: 3.11.0
Zsh version: 5.7.1 (x86_64-apple-darwin19.0.0)
Zsh framework: prezto
Zsh plugin manager: None
Terminal emulator: iTerm2
Operating system: macOS

Screenshot

Provide a screenshot that shows your issue.

[vschoener]

And screen using nvm

[romkatv]

If you have nvm installed, spaceship will show node version only from nvm. It won't look at nodenv. If you uninstall nvm, spaceship will start picking up node version from nodenv.

I'm not a spaceship dev or even a user, so I don't know whether this is intended behavior. It's what the code does.

[vschoener]

Damn, too bad it acts like this :( That would be nice to fallback if nvm is not used.
I just talk about nodenv here in my team as they just nvm, and in my case, I start moving my project to nodenv, so I need to play with both.

[salmanulfarzy]

We use fallback methods to detect various available tools. You could reorder them if you prefer nodeenv before nvm.

https://github.com/denysdovhan/spaceship-prompt/blob/df8180a41451dc0b02870943359bb47a91794854/sections/node.zsh#L31-L41

[luisfarzati]

There's a feature request to make nvm use the .node-version file but not sure there's been any progress on it. nvm-sh/nvm#794

But what you can do is make nodenv read the .nvmrc file and then uninstall that ugly nvm once and for all.