Fix: Do not add a newline before prompt when terminal opens #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysdovhan
reviewed
Jun 12, 2021
|
@denysdovhan I have added a reference to the issue in a comment above the code. Is it correct? |
denysdovhan
added
the
improvement
denysdovhan
changed the title
|
Thanks for contributing! |
denysdovhan
added a commit
that referenced
this pull request
Jun 17, 2021
* Do not add a newline before prompt when terminal opens * Add a reference to the issue in a comment * chore: format comment with a reference Co-authored-by: Denys Dovhan <denysdovhan@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2021
## [3.12.5](v3.12.4...v3.12.5) (2021-06-17) ### Bug Fixes * Do not add a newline before prompt when terminal opens ([#1016](#1016)) ([aaf35d5](aaf35d5))
|
@denysdovhan this makes terminal never show newline. Option |
|
@Runrioter Nope. I have the same issue. |
|
I have reverted these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977
Hi @denysdovhan, how does this look?
Let me know if this needs any changes.
Thanks